#1189: Make data parameter of expression evaluation functions const -------------------------+-------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- The data argument of Util_ExpressionEvaluate, and of the evaluator functions it uses, should be const. data is a pointer to user-supplied data used for evaluating the expression. It should not be modified by the evaluation. Note that this modifies the flesh API to the (undocumented) thorn-visible function Util_ExpressionEvaluate. The attached patch makes this modification as well as modifying the evaluators in the flesh.
OK to apply?
#1189: Make data parameter of expression evaluation functions const --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):
* status: new => review
#1189: Make data parameter of expression evaluation functions const --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Okay to apply.
#1189: Make data parameter of expression evaluation functions const --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Thanks. Committed as r4922 of the flesh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit