[Einstein Toolkit] #1916: GetComponents checks out git repositories serially

List overview All Threads
Download

newer

older

[Einstein Toolkit] #2028:...

[Einstein Toolkit] #614: relative...

Einstein Toolkit

13 Jun 2016 13 Jun '16

6:44 a.m.

#1916: GetComponents checks out git repositories serially ---------------------------+------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: ET_2016_11 Component: GetComponents | Version: development version Keywords: | ---------------------------+------------------------------------------------ When called with --parallel, GetComponents still checks out git repositories serially. This may have been introduced with #83, but there is no information in that ticket about what was done.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

13 Jun 13 Jun

6:51 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: confirmed Priority: major | Milestone: ET_2016_11 Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):

* status: new => confirmed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 Dec 6 Dec

8:58 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: confirmed Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):

* milestone: ET_2016_11 =>

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Feb 12 Feb

4:30 p.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: confirmed Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by rhaas):

I suspect that this is actually due to 6dc98e842bad513ddbc5724ebb4f521823574020 in #1395. If you follow the code then you can see that there is one call to checkout per TARGET instruction the CRL file. However the checkout subroutine serializes the first checkout of each call and since for git there is often one git repo per TARGET (since the url is unique) this means that effectively all git repos are checked out serially.

A full fix would be to track dependencies between checkouts (ie which combination of TARGET/CHECKOUT is contained in other TARGET/CHECKOUTs) and wait for dependencies to be satisfied before continuing.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

13 Feb 13 Feb

8:21 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):

* status: confirmed => review

Comment:

Pull request is here: https://github.com/gridaphobe/CRL/pull/4/files

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 Mar 6 Mar

10 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by rhaas):

Could someone review this please? If not I will push it without external review after Monday March 13th.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Apr 12 Apr

10:30 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by rhaas):

Applied as git hash d22e54d of CRL.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:30 a.m.

#1916: GetComponents checks out git repositories serially ----------------------------+----------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: GetComponents | Version: development version Resolution: fixed | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):

* status: review => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1916#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3466

Age (days ago)

3769

Last active (days ago)

trac@lists.einsteintoolkit.org

7 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit