#1880: AHFinderDirect fix on-off issue setting mask when not finding AH every single step ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: AHFinderDirect ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

#1880: AHFinderDirect fix on-off issue setting mask when not finding AH every single step ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: AHFinderDirect ------------------------------------+---------------------------------------

Comment (by rhaas):

Are there any more objections to pushing this? I took care of the issues mentioned in the comments in two new commits. Unless there are objections I will push these changes before Saturday.

#1880: AHFinderDirect fix on-off issue setting mask when not finding AH every single step ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: AHFinderDirect ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: closed => reopened * resolution: fixed =>

Comment:

This causes failures in test of Dissipation that use extra dissipation inside of the AH: https://build.barrywardell.net/job/EinsteinToolkitFull/217/testReport/junit/... and https://build.barrywardell.net/job/EinsteinToolkitFull/217/testReport/junit/... which are due to changing the scheduling from global (=global-late in ANALYSIS) to global-early. This means that with the change, the apparent horizon is actually recorded correctly in epsdisA. I attach diff files of before (right) and after (left) applying the change. Due to the way loop- local works this is not quite what the code would have seen in EVOL since loop-local loops over all components in all refinement levels not just the ones a local routine would execute on during this timestep.

#1880: AHFinderDirect fix on-off issue setting mask when not finding AH every single step ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: rhaas Type: defect | Status: assigned Priority: minor | Milestone: ET_2016_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: AHFinderDirect ------------------------------------+--------------------------------------- Changes (by knarf):

* owner: => rhaas * status: reopened => assigned * milestone: => ET_2016_05

Comment:

Roland: can you please regenerate the relevant data files?

#1880: AHFinderDirect fix on-off issue setting mask when not finding AH every single step ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: rhaas Type: defect | Status: closed Priority: minor | Milestone: ET_2016_05 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: AHFinderDirect ------------------------------------+--------------------------------------- Changes (by knarf):

* status: assigned => closed * resolution: => fixed