#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces -----------------------------------+---------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- The following pull-request should be looked at:
https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/2 /modification-for-work-phys-rev-d93-064047/diff
As described there, this includes:
Modification for work: Phys. Rev. D93, 064047 (2016), arXiv:1509.08804 Now it support hybrid EOS with up to ten pieces Bug corrected on allocation of teh paramter set for back- compatibility EOS_Omni: remove space
Note that the diff as shown on butbucket is mis-leading. It mixes parameter names and values in ways that easily lead to misunderstandings.
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* status: new => review
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+--------------------------------------- Changes (by knarf):
* keywords: => parma
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+---------------------------------------
Comment (by knarf):
ping, I need a review.
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reopened
Comment:
Comments are in the pull request. Basically: the code is fine, the physics as well (I had tested against another code and re-derived most of the expressions).
I am not sure if it should go in right away as it is unclear how much of a speed impact (for example) the loops over pieces have and *also* for the fact that this is a backwards incompatible change very shortly before the release. It does seem to introduce a handful of changes of behaviour which should not go into the ET without testing first.
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+---------------------------------------
Comment (by rhaas):
Thanks for pointing out my misreading of the diff. I did not look carefully enough at it apparently. I re-shuffled the lines to make the diff simpler (which mixes old and new parameters, which I guess explains why the parameters were shuffled in the first place) and the only leftover comment is the one on poly_gamma_ini (and speed technically): https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/3/rhaas- parma/diff
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reopened => review
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
After consultation and discussion: please apply.
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: parma ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
This has already been merged in git hash b2c251c "Merged in PARMA (pull request #2)" of cactuseos.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit