#1972: GetComponents fails if the target path contains a space ---------------------------+------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: new Priority: blocker | Milestone: Component: GetComponents | Version: development version Keywords: | ---------------------------+------------------------------------------------ The following fails: {{{ mkdir "Google Drive" cd "Google Drive" GetComponents https://bitbucket.org/einsteintoolkit/manifest/raw/ET_2016_05/einsteintoolki... }}} since the git handler (at least) does not properly quote the arguments it passes to git and git complains about too many arguments.
Related to this: GetComponents does not output stderr for failed commands and it likely should (this may involve interfacing with Perl's IPC module).
#1972: GetComponents fails if the target path contains a space ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: blocker | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------
Comment (by rhaas):
A pull request can be found here: https://github.com/gridaphobe/CRL/pull/2 basically it removes the use of "$orig_dir" (the absolute path of the directory GetComponents was called from) from the script.
#1972: GetComponents fails if the target path contains a space ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: blocker | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: new => review
#1972: GetComponents fails if the target path contains a space ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2016_11 Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):
* milestone: => ET_2016_11
Comment:
Would be nice before the release. Potential big usability improvement, and small patch.
#1972: GetComponents fails if the target path contains a space ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: blocker | Milestone: ET_2016_11 Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1972: GetComponents fails if the target path contains a space ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2016_11 Component: GetComponents | Version: development version Resolution: fixed | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit