#1862: Patch: make Refluxing infrastructure independent of GRHydro -----------------------------------+---------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- GRHydro can optionally run with conservative AMR using the "Refluxing" thorn. The infrastructure for refluxing is very generic, but the "Refluxing" thorn currently contains GRHydro-specific code that makes it incompatible with any other solver.
To overcome this limitation, I prepared:
1. A patched version of the Refluxing thorn, with a generic MoL-like registration mechanism for the fluxes 2. A new thorn containing all of the old GRHydro-specific code from Refluxing.
The new code passes all existing tests and allow other (M)HD thorns to register variables for refluxing in a very simple way. The code is in two git repositories on bitbucket:
https://bitbucket.org/dradice/refluxing https://bitbucket.org/dradice/grhydro_refluxing
Notes:
1. GRHydro parfiles that use conservative AMR should be modified to include GRHydro_Refluxing 2. The new Refluxing thorn no longer supports delayed refluxing, which was never used for any production run, and/or special GRHydro-specific atmosphere hacks.
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by dradice@…):
* status: new => review
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
I added minor comments on grhydro_refluxing to https://bitbucket.org/dradice/grhydro_refluxing/commits/8f972d5dd86c72cb9fe6... . Nothing big, mostly just some unused routines (are yout ''supposed'' to be unused ?) and a request to not use sprintf and to document a purpose for the thorn. Otherwise grhydro_refluxing is fine with me.
I added a single minor comment to refluxing here https://bitbucket.org/dradice/refluxing/commits/faad5bc55245e102022a958dde69... .
Note that the new refluxing removes various experimental code that never quite worked as desired. This is with approval of the author (Erik) and user (Christian Reisswig) for whom these were added (as far as I know). While this technically removes features from an ET thorn, the features were highly experimental.
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
David: do you want to apply your patches?
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by dradice@…):
Roland: the latest version of the GRHydro_Refluxing thorn should address your questions. I have not changed the parameter name in the Refluxing thorn: do you consider it necessary for inclusion in the ET?
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Nono, renaming the parameter is purely optional.
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by dradice@…):
Ok, I would prefer not to change the parameter name then.
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: ET_2016_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* milestone: => ET_2016_11
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: ET_2016_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
GRHydro_Refluxing is introduced into EinsteinEvolve in git hash 54dce1f of EinsteinEvolve.
#1862: Patch: make Refluxing infrastructure independent of GRHydro ------------------------------------+--------------------------------------- Reporter: dradice@… | Owner: Type: enhancement | Status: closed Priority: major | Milestone: ET_2016_11 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied to Refluxing in revision 77 of Refluxing.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit