[Einstein Toolkit] #1985: GetCOmponents does not follow HTTP redirection when downloading via curl
#1985: GetCOmponents does not follow HTTP redirection when downloading via curl ---------------------------+------------------------------------------------ Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: GetComponents | Version: development version Keywords: | ---------------------------+------------------------------------------------ The pull request:
https://github.com/gridaphobe/CRL/pull/3
adds {{{--location}}} to curl calls to make curl follow redirects. wget follows the redirect without further options.
The branch also contains two cleanup commits that remove unused code.
#1985: GetCOmponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: new => review
#1985: GetComponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------
#1985: GetComponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------
Comment (by knarf):
commented on the patch in github
#1985: GetComponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------
Comment (by rhaas):
Replying to [comment:3 knarf]:
commented on the patch in github
I see no comments on https://github.com/gridaphobe/CRL/pull/3/files and do not seem to be able to recover any older conversation (nor any older versions from my local git history incl. the reflog). Would you mind checking over this once more, please? If it is ok I'll commit or will commit anyway after next Monday if there is no review at all.
#1985: GetComponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: fixed | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied as git hash 1c4d724 or CRL.
#1985: GetComponents does not follow HTTP redirection when downloading via curl ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: fixed | Keywords: ----------------------------+-----------------------------------------------
Comment (by knarf):
I see my comments when I expanded the 'outdated'. They say:
line 1785 and 1813: Why is this added twice here? (referring to the option --location added twice to the same command)
trac@lists.einsteintoolkit.org
-
Einstein Toolkit