#1615: TOVSolver shares parameters from GRHydro -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: TOVSolver | -----------------------------------+---------------------------------------- Zach Etienne was looking at TOVSolver to use it for a test case in IllinoisGRMHD (and to compare to GRHydro). He found that it
Turns out all but one of the parameters that are shared with GRHydro are unused in TOVSolver: These need to be removed: USES real rho_abs_min USES real rho_rel_min USES REAL initial_rho_abs_min USES REAL initial_rho_rel_min USES REAL initial_atmosphere_factor
and that the one shared parameter that is actually used is GRHydro_rho_central.
My suggestion would to remove these dependencies so that the initial data thorn can be used with other evolution thorns.
#1615: TOVSolver shares parameters from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: TOVSolver ------------------------------------+---------------------------------------
Comment (by knarf):
The unused parameters can certainly be removed. They are left-overs from when TOVSolver did indeed handle the atmosphere, and looked at these parameters. I am unsure about GRHydro_rho_central. I believe it should be unused in any relevant parameter file, but we might need to update a testsuite parameter file or two. Otherwise yes - all of these should go, and I would love to make TOVSolver independent of GRHydro.
#1615: TOVSolver shares parameters from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: TOVSolver ------------------------------------+--------------------------------------- Changes (by knarf):
* status: new => closed * resolution: => fixed
#1615: TOVSolver shares parameters from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: TOVSolver ------------------------------------+---------------------------------------
Comment (by rhaas):
The fix was applied in git hash 641bd06d0878c6717fb185c23f0aa2ca3446e85a of EinsteinInitial.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit