[Einstein Toolkit] #1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid
#1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid ----------------------------------------+----------------------------------- Reporter: reisswig@… | Type: defect Status: new | Priority: major Milestone: | Component: EinsteinToolkit thorn Version: | Keywords: ----------------------------------------+----------------------------------- Problem: My horizon will appear sometimes during the simulation at some position. I don't know this position in advance, so I set origin_* and AHFinderDirect::initial_guess__coord_sphere__*_center to zero initially in my par-file. However, I have a grid scalar which tracks the coordinate location where the horizon will eventually appear. When the horizon finder starts to search for a horizon, it will first setup the coordinate ellipsoid. This routine is executed *before* the new origin is set from the grid scalar. The tracking occurs in the routine Newton(...). The ellipsoid is set before Newton(...) gets executed. Hence, the ellipsoid uses the value that got set via parameters (which would be zero in my case).
#1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: -----------------------------------------+----------------------------------
Comment (by reisswig@…):
I have the following patch: When track_origin_from_grid_scalar = yes, we never look for the initial guess parameters (instead, we use the sensible choice that they should be the same as the tracked origin).
I have introduced two new routines for this: track_origin -> sets ps.origin() from grid scalar set_initial_guess_parameters -> set initial guesses according to parameters; or to customly provided initial guess (e.g. via a preceeding call to track_origin).
#1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: -----------------------------------------+---------------------------------- Changes (by rhaas):
* status: new => review
#1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: -----------------------------------------+---------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Please apply (will do myself).
#1241: AHFinderDirect is not using the correct origin when "track_origin_from_grid_scalar = yes" when setting up ellipsoid -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: -----------------------------------------+---------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as AHFinderDirect rev 1573.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit