#1323: remove make.code.deps from GRHydro -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro | -----------------------------------+---------------------------------------- GRHydro contains a file make.code.deps which tries to list the dependencies among its files due to Fortran modules. Naturally the file is out of date. Reading the documentation this should be harmless as make.code.deps should only give additional dependency information. However I just had a case where removing the file (and -cleandeps) helped. The actual fix could thus have been the cleandeps as well.
make.code.deps is not required in this case since Cactus can track module dependency on its own (see http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-9... and http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-6...).
This patch removes the file.
#1323: remove make.code.deps from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1323: remove make.code.deps from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved.
Note: - the variables defined in modules should probably have the SAVE attribute - including cctk_Arguments.h or cctk_Parameters.h is not necessary - the variable coeffs_allocated should probably be removed, as Fortran provides an ALLOCATED intrinsic
#1323: remove make.code.deps from GRHydro ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in rev 506 and 507 of GRHydro (also remove include files and coeffs_allocated and adds SAVE attributes).
trac@lists.einsteintoolkit.org
-
Einstein Toolkit