[Einstein Toolkit] #825: CST hangs if given recursive schedule group dependencies

List overview All Threads
Download

newer

older

[Einstein Toolkit] #829: openssl...

[Einstein Toolkit] #833: Cannot...

Einstein Toolkit

23 Apr 2012 23 Apr '12

11:49 a.m.

#825: CST hangs if given recursive schedule group dependencies --------------------+------------------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: Keywords: | --------------------+------------------------------------------------------- If a schedule.ccl file contains

schedule group A in A

the CST hangs at "Creating schedule bindings...". This error in the schedule.ccl file should be detected and a fatal error message should be generated.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

23 Apr 23 Apr

12:05 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete (was: CST hangs if given recursive schedule group dependencies)

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: accepted Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* owner: => knarf * status: new => accepted

Comment:

The problem isn't the recursion (alone), but the missing {}"" block after this. the following shows the same:

{{{ schedule group A in B }}}

while this doesn't hang:

{{{ schedule group A in A { } "" }}}

I believe cyclic dependencies are checked at runtime only, but I didn't check A->A

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:32 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: review Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: accepted => review * milestone: => ET_2012_05

Comment:

Please review the attached patch which solves the problem for me. I request two 'yes' because of the sensitive place (CST).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:22 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: review Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by eschnett):

Scheduling a group in itself is possible in Cactus. One has to disable printing the schedule, though. This does make sense if there is an IF or a WHILE modifier.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

29 Apr 29 Apr

10:19 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: review Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by knarf):

This patch doesn't change the ability to schedule something within itself. It only fixes the hang, which is unrelated to this. The patch is really simple: it is a one-line change checking whether the end of the file has been reached before trying (an otherwise always) failing regexp. I still need to "yes".

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:55 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: review Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by rhaas):

Patch is fine by me.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

30 Apr 30 Apr

9:15 a.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: review_ok Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):

* status: review => review_ok

Comment:

Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:22 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: review_ok => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:23 p.m.

New subject: [Einstein Toolkit] #825: CST hangs if scheduling block isn't complete

#825: CST hangs if scheduling block isn't complete ---------------------+------------------------------------------------------ Reporter: hinder | Owner: knarf Type: defect | Status: closed Priority: major | Milestone: ET_2012_05 Component: Cactus | Version: Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: reviewed_ok => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/825#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5274

Age (days ago)

5282

Last active (days ago)

trac@lists.einsteintoolkit.org

8 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit