#865: Add autoconf macro to test for OpenMP collapse statement ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | ----------------------+-----------------------------------------------------
#865: Add autoconf macro to test for OpenMP collapse statement -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by eschnett):
It turns out that it would be difficult to create an actual autoconf test, since the symptoms are bad behaviour at run time. Instead, we should check the compiler vendor or version
I checked, and #defining collapse(N) should work fine.
#865: Add autoconf macro to test for OpenMP collapse statement -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => review
#865: Add autoconf macro to test for OpenMP collapse statement -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Patch looks ok. One comment: maybe we want to add a define for COLLAPSE (uppercase) as well as collapse for the Fortran case to provide some case insensitivity (assuming that no one spells collapse as "CoLllaSE" in Fortran even though they migh).
#865: Add autoconf macro to test for OpenMP collapse statement -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Added upper-case version. Applied.
trac@lists.einsteintoolkit.org