[Einstein Toolkit] #1617: Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData
#1617: Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData -----------------------------------+---------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Cactus_4.3.0 Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData, otherwise there's a risk of seg fault in Accelerator_NotifyDataModified due to a missing accelerator data structure. MoL fails to do this in Operators.c. Patch attached.
#1617: Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData ------------------------------------+--------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Cactus_4.3.0 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Moving the initialization of is_device outside the if block is not necessary. It is also dangerous, because it will not have its correct value there.
The first hunk of interface.ccl does not correspond to the current version in svn; in fact, it seems to correct a severe syntax error. Are you sure you started your diff against the current tree? Are you using "svn diff"?
#1617: Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData ------------------------------------+--------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Cactus_4.3.0 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Is the actual fix in there (calling {{{Accelerator_RequireInvalidData}}}) still required?
#1617: Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData ------------------------------------+--------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: closed Priority: minor | Milestone: Cactus_4.3.0 Component: EinsteinToolkit thorn | Version: development version Resolution: invalid | Keywords: ------------------------------------+--------------------------------------- Changes (by sbrandt):
* status: new => closed * resolution: => invalid
Comment:
Seems not to be a problem any longer.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit