[Einstein Toolkit] #1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no"
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" --------------------+------------------------------------------------------- Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- CarpetLib::interpolate_from_buffer_zones should by default set to "no" after it is properly tested and we should think about whether we have a good reason to not remove that paramter then again. Adding the release tag because we don't want to have a change like this affecting two releases.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Has this been tested?
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
Not by me.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by hinder):
We probably don't want to change numerical results just before a release. I don't understand Frank's comments about affecting two releases; what did you mean Frank? I propose that we change the default after the upcoming release, when we can test it properly. We should keep the parameter so that people can check that their numerical results have changed only as a result of this change. After the next release, we can drop the parameter.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
We would now add a note to the release notes that this parameter should be set to "no" to have proper behavior (but this is apparently not well tested yet), in a later release the default might change, in a later release we would deprecate that parameter and at a yet late release we would remove it again.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
This is now mentioned in the release notes. Moving the milestone.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: ET_2013_05 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* milestone: ET_2012_11 => ET_2013_05
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: ET_2013_05 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: new => review
Comment:
Volunteers for testing, please?
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: ET_2013_05 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Since the new behaviour seems "more correct", I will make it the default.
#1099: CarpetLib::interpolate_from_buffer_zones should by default set to "no" ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: closed Priority: major | Milestone: ET_2013_05 Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit