#890: Fix to ePPM reconstruction ----------------------+----------------------------------------------------- Reporter: reisswig | Type: defect Status: new | Priority: major Milestone: | Component: EinsteinToolkit thorn Version: | Keywords: GRHydro, ePPM ----------------------+----------------------------------------------------- This is a bug fix to the ePPM scheme. The velocity components were reconstructed from the plus face values! This is clearly incorrect.
#890: Fix to ePPM reconstruction ------------------------------------+--------------------------------------- Reporter: reisswig | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro, ePPM ------------------------------------+---------------------------------------
Comment (by rhaas):
Patch looks fine to me. Please apply (to Zelmani or GRHydro). BTW this patch is a reverse patch without any information on which file to apply it (looking at the code in the file and patch: GRHydro/src/GRHydro_PPM.F90). You can use "git diff" is instead of just a plain diff to have it include the source and target file information.
#890: Fix to ePPM reconstruction ------------------------------------+--------------------------------------- Reporter: reisswig | Owner: rhaas Type: defect | Status: accepted Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro, ePPM ------------------------------------+--------------------------------------- Changes (by rhaas):
* owner: => rhaas * status: new => accepted
#890: Fix to ePPM reconstruction ------------------------------------+--------------------------------------- Reporter: reisswig | Owner: rhaas Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro, ePPM ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: accepted => closed * resolution: => fixed
Comment:
applied.
trac@lists.einsteintoolkit.org