#1264: only install those hdf5 utils that we find/could build -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: HDF5 | -----------------------------------+---------------------------------------- the attached patch only tries to install those hdf5 utilities that were eihter build by us or can be found in HDF5_DIR/bin since eg. a sytem package provides them.
This helps with users that use the system provided hdf5 package but do not install the hdf5-tools package (package names are debian names).
#1264: only install those hdf5 utils that we find/could build ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HDF5 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1264: only install those hdf5 utils that we find/could build ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HDF5 ------------------------------------+---------------------------------------
Comment (by eschnett):
The first half of the patch is fine. Instead of a wildcard expansion, you can also call "ls" with the respective file names, ignore errors, and this will then output only those files that exist.
The second half of the patch is also interesting. However, I suggest to use the "done" file to store options instead of creating a new "options" file. The "done" file would then contain a fingerprint of the current installation, and changes to this fingerprint would cause a rebuild.
#1264: only install those hdf5 utils that we find/could build ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HDF5 ------------------------------------+---------------------------------------
Comment (by rhaas):
updated patch for first half. Second half will appear eventually in 1017.
#1264: only install those hdf5 utils that we find/could build ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HDF5 ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1264: only install those hdf5 utils that we find/could build ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: HDF5 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied (first part of patch) as rev 69 of HDF5.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit