#742: Let OpenCL print available platform and device info on startup -------------------------+-------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- This patch lets the OpenCL thorn print information about available platforms and devices on startup.
#742: Let OpenCL print available platform and device info on startup --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: new => review
#742: Let OpenCL print available platform and device info on startup --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
This is a good idea. Please apply, after correcting the problems below.
The patch has two problems: 1. It defines a globally visible function err_code -- that should be a static function, or have a longer name, or have e.g. an OpenCL_ prefix. 2. It calls malloc without calling free; given that it already requires a very modern cpp (with vararg macros), it could use automatic arrays instead.
#742: Let OpenCL print available platform and device info on startup --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
I uploaded a new patch. This renames err_code to OpenCL_err_code (at some point we might want to make this public using proper Cactus mechanisms, but that can be done later). It also uses automatic arrays now.
#742: Let OpenCL print available platform and device info on startup --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Please apply.
#742: Let OpenCL print available platform and device info on startup --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: review => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit