#1245: remove poly_gamma_ini from EOS_Omni -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: EOS_Omni | -----------------------------------+---------------------------------------- eos omni uses this to compute (initially) conversion factors from code (assumed to e G=c=M_sun=1) to cgs units. It then goes back and forth between these units even for polytropic and gamma law eos. This is very confusing since poly_gamma_ini since poly_gamma_ini must mast poly_gamma and gl_gamma for a "usual" run with a Gamma law eos.
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+---------------------------------------
Comment (by knarf):
This also relates to #1070. The big question is: is someone actually using the parameter to set different EOS initially and for evolution?
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+---------------------------------------
Comment (by rhaas):
I have to admit I am not even sure if this is what poly_gamma_ini does or if it is intended to do this. Certainly we have users setting it incorrectly. Also I would think that changing EOS from initial data to evolution is not something that the EOS thorn should do. Removing the parameter will loudly abort while leaving it in in the current fashion gives silently non-sensical results.
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
Let's remove this parameter. Usually I would argue that we should not remove it completely but make it a dummy and complain if it is used. However, that is what (more or less) will happen anyway if the parameter is removed.
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+---------------------------------------
Comment (by knarf):
trigger.patch is applied
#1245: remove poly_gamma_ini from EOS_Omni ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: EOS_Omni ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Thank you. Applied in rev 73 (eos_omni), rev 62 (refluxing) and rev 31 (trigger).
trac@lists.einsteintoolkit.org
-
Einstein Toolkit