#498: McLachlan doesn't check metric_type -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- McLachlan doesn't check the metric type, which needs to be "physical". A static conformal factor is not supported.
#498: McLachlan doesn't check metric_type ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Actually, McLachlan should check the grid scalar conformal_state, not the parameter metric_type.
#498: McLachlan doesn't check metric_type ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
In general: who is using a static conformal factor these days? If nobody really, I suggest to mark this depreciated for the next release and remove it for the one following that.
#498: McLachlan doesn't check metric_type ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
It is used in current example parameter files, and mostly unsuspecting people will trip over it. We could mark it as deprecated, but would then need to update these examples (and possibly test cases).
#498: McLachlan doesn't check metric_type ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
I certainly wouldn't put any effort into making McLachlan know about this. Instead spend the time on updating the test cases.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit