[Einstein Toolkit] #1297: Reduce time spent in cycling timelevels if there is only one timelevel.
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------------------+------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: new Priority: major | Milestone: Component: Carpet | Version: development version Keywords: performance optimization | --------------------------------------+------------------------------------- I noticed in a run with gridfunctions with only 1 timelevels that a significant amount of time was spent cycling timelevels. The attached patch makes the routine bypass a lot of code, if a grid variable only has 1 timelevel. This reduces the total time spent in cycling timelevels from 417 s to 0.8 s for a run of 32767 iterations.
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------+------------------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: performance optimization --------------------------+------------------------------------------------- Changes (by diener):
* status: new => review
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------+------------------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: performance optimization --------------------------+-------------------------------------------------
Comment (by eschnett):
Do you know in what parts of the code all the time was spent? Maybe these parts should be optimized anyway, so that other simulations could benefit as well.
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------+------------------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: performance optimization --------------------------+-------------------------------------------------
Comment (by diener):
No, I only got one timer number for the whole routine. I could look at it in more detail with vtune but the time spent in the routine per call is only 0.012 s, so it might be difficult to sensible numbers.
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------+------------------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: performance optimization --------------------------+------------------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
It seems simple enough. Please apply.
#1297: Reduce time spent in cycling timelevels if there is only one timelevel. --------------------------+------------------------------------------------- Reporter: diener | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: performance optimization --------------------------+------------------------------------------------- Changes (by diener):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Committed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit