[Einstein Toolkit] #1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage.
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. -----------------------------------+---------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro Tmunu storage | -----------------------------------+---------------------------------------- The attached patch schedule GRHydro_Tmunu* only if there is Tmunu storage.
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro Tmunu storage ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: new => review
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro Tmunu storage ------------------------------------+---------------------------------------
Comment (by rhaas):
The patch itself looks ok. I am not sure though if this is required at all. TmunuBase itself already contains a statement: {{{ if (stress_energy_storage) { ... SCHEDULE GROUP AddToTmunu IN SetTmunu AFTER (TmunuBase_SetTmunu,TmunuBase_ZeroTmunu) { } "Add to the stress-energy tensor here" ... } }}} so that the whole AddToTmunu group is never scheduled unless stress_energy_state is true (or at least unless the parameter value that will be copied into stress_energy_state is true).
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro Tmunu storage ------------------------------------+---------------------------------------
Comment (by rhaas):
Bruno: do you still think that the patch is required? If not, would you mind closing the ticket, please?
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro Tmunu storage ------------------------------------+--------------------------------------- Changes (by anonymous):
* status: review => reopened
Comment:
No, I don't think so. Thanks. I will close it as invalid.
#1068: GRHydro: schedule GRHydro_Tmunu* only if there is Tmunu storage. ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: invalid | Keywords: GRHydro Tmunu storage ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: reopened => closed * resolution: => invalid
trac@lists.einsteintoolkit.org
-
Einstein Toolkit