#315: SimRestart instance has no attribute 'SimulationDir' ------------------------+--------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Keywords: | ------------------------+--------------------------------------------------- Using r1234, I cannot clean up a simulation on damiana. I get the error:
AttributeError: SimRestart instance has no attribute 'SimulationDir'
I thought that these things should be picked up by pychecker?
[ianhin@login-damiana llama]$ sim2 cleanup --machine datura bbhllama_22a Info: Simfactory command: simfactory2/bin/../lib/sim.py "cleanup" "-- machine" "datura" "bbhllama_22a" Info: Version exported The Simulation Factory: Manage Cactus simulations
Info: defs: /home/ianhin/Cactus/llama/simfactory2/etc/defs.ini Info: defs.local: /home/ianhin/Cactus/llama/simfactory2/etc/defs.local.ini Info: Cactus Directory: /home/ianhin/Cactus/llama Info: simenv.COMMAND: cleanup Info: Executing command: cleanup Info: Simulation name: bbhllama_22a Traceback (most recent call last): File "simfactory2/bin/../lib/sim.py", line 141, in ? main() File "simfactory2/bin/../lib/sim.py", line 138, in main CommandDispatch() File "simfactory2/bin/../lib/sim.py", line 105, in CommandDispatch module.main() File "/home/ianhin/Cactus/llama/simfactory2/lib/sim-manage.py", line 335, in main CommandDispatch() File "/home/ianhin/Cactus/llama/simfactory2/lib/sim-manage.py", line 314, in CommandDispatch exec("command_%s()" % command) File "<string>", line 1, in ? File "/home/ianhin/Cactus/llama/simfactory2/lib/sim-manage.py", line 70, in command_cleanup rids = restartlib.GetRestartIds(restart) File "/home/ianhin/Cactus/llama/simfactory2/lib/restartlib.py", line 380, in GetRestartIds simulationdir = restart.SimulationDir AttributeError: SimRestart instance has no attribute 'SimulationDir'
#315: Cannot cleanup simulations -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
#315: Cannot cleanup simulations -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by hinder):
This also happens on Kraken, so it is likely a generic problem not specific to Datura.
#315: Cannot cleanup simulations -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: closed Priority: major | Milestone: Component: SimFactory | Version: Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by mthomas):
* status: new => closed * resolution: => fixed
Comment:
this bug has been fixed as of revision r1257
#315: Cannot cleanup simulations -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: reopened Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by hinder):
* status: closed => reopened * resolution: fixed =>
Comment:
I've updated SimFactory and attempted to clean up my existing simulation. The error message has now changed from
SimRestart instance has no attribute 'SimulationDir'
to
AttributeError: SimRestart instance has no attribute 'RestartDir'
The full output is:
[hinder@kraken-pwd4 llama]$ simfactory2/bin/sim cleanup bbhllama_20a Info: Simfactory command: simfactory2/bin/../lib/sim.py "cleanup" "bbhllama_20a" Info: Version sh: svnversion: command not found The Simulation Factory: Manage Cactus simulations
Info: defs: /nics/d/home/hinder/Cactus/llama/simfactory2/etc/defs.ini Info: defs.local: /nics/d/home/hinder/Cactus/llama/simfactory2/etc/defs.local.ini Info: Cactus Directory: /nics/d/home/hinder/Cactus/llama Info: simenv.COMMAND: cleanup Info: Executing command: cleanup Info: Simulation name: bbhllama_20a Traceback (most recent call last): File "simfactory2/bin/../lib/sim.py", line 142, in ? main() File "simfactory2/bin/../lib/sim.py", line 138, in main CommandDispatch() File "simfactory2/bin/../lib/sim.py", line 105, in CommandDispatch module.main() File "/nics/d/home/hinder/Cactus/llama/simfactory2/lib/sim-manage.py", line 339, in main CommandDispatch() File "/nics/d/home/hinder/Cactus/llama/simfactory2/lib/sim-manage.py", line 318, in CommandDispatch exec("command_%s()" % command) File "<string>", line 1, in ? File "/nics/d/home/hinder/Cactus/llama/simfactory2/lib/sim-manage.py", line 73, in command_cleanup restart.finish() File "/nics/d/home/hinder/Cactus/llama/simfactory2/lib/simrestart.py", line 1381, in finish active_dir = "%s-active" % self.RestartDir AttributeError: SimRestart instance has no attribute 'RestartDir'
#315: Cannot cleanup simulations -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: closed Priority: major | Milestone: Component: SimFactory | Version: Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by mthomas):
* status: reopened => closed * resolution: => fixed
Comment:
okay. I've finally corrected this (and fully tested it).
r1282.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit