[Einstein Toolkit] #1345: Cactus shouldn't mess with some flags after they have been setup.
#1345: Cactus shouldn't mess with some flags after they have been setup. --------------------+------------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: new Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Keywords: | --------------------+------------------------------------------------------- Currently Cactus sets up flags like CPPFLAGS or CFLAGS by adding e.g. CPP_OPENMP_FLAGS. However, later it overwrites these again by their original value in sbin/ProcessConfiguration.pl (search for FIXME).
The attached patch implements what the 'FIXME' suggests - accepting the drawbacks that are mentioned there: that configuration settings not originating from a thorn might not be forwarded from e.g., a .cactus/config file. MPI was one of these, but this is now handled differently anyway. With this patch, we would need to be aware of these and might need to add them to @allowed_opts in the future.
Without the patch however, compilation might fail for perfectly valid setups. One of these is when using openmp, setting all the corresponding *_OPENMP_FLAGS, but not setting CPPFLAGS (only CPP_OPENMP_FLAGS). In this case ProcessConfiguration.pl will set CFLAGS to the version in the config file (*without* the -openmp), but it will leave CPPFLAGS to the version *with* -openmp. This later leads to a linker error in external libraries, since compilation there uses CPPFLAGS (with openmp), but the linker doesn't (It correctly uses CFLAGS, but this doesn't have openmp flags here).
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* status: new => review
Comment:
To be applied after the spring release.
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Where is @allowed_opts set?
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
It's populated by what thorns define (in ProcessConfiguration.pl).
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
This also breaks building 'curl'.
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Curl is building fine for me, as do all other thorns in ExternalLibraries. What are your setting and symptoms?
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
Same as above. A build fails when using openmp, set using C_OPENMP_FLAGS (and corresponding), but not defining CPPFLAGS. For the release we can use a workaround to define CPPFLAGS (as empty), but this should be cleaned up later.
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
ping?
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
I never used a global .config file. So if that is the only thing that possibly breaks. Fine with me.
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
It's the only thing I am aware of. Now (just after a release) is probably the best time to get it into the development version I would think. Ok to apply?
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
please apply.
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: review => reviewed_ok
#1345: Cactus shouldn't mess with some flags after they have been setup. ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: closed Priority: major | Milestone: ET_2013_11 Component: Other | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as r5034.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit