#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- See <https://bitbucket.org/cactuscode/cactus/pull-request/15/cactus- remove-support-for-have_cctk_c_bool/diff>.
#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
This seems to remove code that was always commented out in the C case: no objections to this. It also removes so support for (old?) C++ compilers that do not support bool types. I really hope all C++ compilers by now support bool types, yet is there a failure that forces us to remove the C++ check (ie does the current behaviour break anything on any machine)? In the case it is decided to tremove this, I would also remove the checks from aclocal.m4 and configure.in not just cctk_Config.h.in.
#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
There is no failure. The code is completely unused.
I now also remove the autoconf macros.
#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Please apply.
#1788: Remove support for HAVE_CCTK_C_BOOL and HAVE_CCTK_CXX_BOOL --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit