#1930: GRHydro_InitData -> HydroBase_InitData? --------------------------------+------------------------------------------- Reporter: zachetie@… | Owner: Type: enhancement | Status: new Priority: unset | Milestone: Component: Other | Version: development version Keywords: | --------------------------------+------------------------------------------- GRHydro_InitData seems to clash with the modern ET approach of making initial data thorns link only to HydroBase/ADMBase (i.e., being evolution- code agnostic), so that any evolution code may take advantage of the functionality.
With slight modifications (possibly requiring the creation of a simple GRHydro compatibility layer thorn, a la "ID_converter_ILGRMHD"), this thorn could be made useful to all HydroBase-compatible GRMHD codes.
#1930: GRHydro_InitData -> HydroBase_InitData? ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: enhancement | Status: new Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------
Comment (by rhaas):
{{{GRHydro_Initdata}}} carries a lot of old baggage from when it was still {{{Whisky_InitData}}} and both primitive and conserved variables lived in the same thorn (Whisky). It also provides more than just ID in, namely the con2prim2con tests.
If you would like to propose changes to remove its tight binding to GRHydro (or separate those out) that would be very useful. The ID-only thorn could be named {{{Hydro_InitData}}} to remove its connection to {{{GRHydro}}}
trac@lists.einsteintoolkit.org
-
Einstein Toolkit