#1200: Sliced HDF5 output index file not stored correctly -------------------------------------+-------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Keywords: | -------------------------------------+-------------------------------------- Index HDF5 datafiles appear to be not handled correctly in the case of sliced data. The files are created and initialized correctly at the first iteration, but every subsequent access fails with an HDF5 error.
I am attaching the output of a simulation showing the issue as well as a patch the fixes the problem for me.
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: | Keywords: --------------------------------------+------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
This patch is obviously correct. Please apply.
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: | Keywords: --------------------------------------+------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: | Keywords: --------------------------------------+-------------------------------------
Comment (by david.radice@…):
I cannot commit the patch, as I do not have write access to the carpet repository...
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: | Keywords: --------------------------------------+-------------------------------------
Comment (by rhaas):
Applied as hash 2c6ced8b7e84af5509e58d09865a88b52385321e "CarpetIOHDF5: Sliced HDF5 output index file not stored correctly" of Carpet. I even could assign authorship to David (so don't trust authorship in commits anymore, anybody could claim to be Erik :-) ).
Given how obviously correct the patch is and that this would prevent any run from using sliced output with index files: ok to also apply to the release branch of Carpet?
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: | Keywords: --------------------------------------+-------------------------------------
Comment (by eschnett):
Obviously yes.
#1200: Sliced HDF5 output index file not stored correctly --------------------------------------+------------------------------------- Reporter: david.radice@… | Owner: eschnett Type: defect | Status: closed Priority: major | Milestone: Component: Carpet | Version: ET_2012_05 Resolution: fixed | Keywords: --------------------------------------+------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied to release branch ET_2012_11 as hash 2a20fc016656be5c464529223ac7079bc9979c24.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit