[Einstein Toolkit] #1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt()
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Other | Version: development version Keywords: OutsideMask | -------------------------+-------------------------------------------------- OutsideMask neglects to include math.h in src/update_mask.c which causes sqrt() to be implicitly defined as int sqrt() which causes distance estimates to be incorrect (most likely random since a double result is likely returned in some other way than an int result).
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: OutsideMask ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: OutsideMask ---------------------+------------------------------------------------------
Comment (by eschnett):
Please do not submit patches like this; they should instead be immediately committed as "obvious", except during a freeze.
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: OutsideMask ---------------------+------------------------------------------------------
Comment (by rhaas):
I'd love to. I have however no commit rights to the repository in question. I have asked for access and pointed to this ticket (which is the only reason I created the ticket).
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: OutsideMask ---------------------+------------------------------------------------------ Changes (by anonymous):
* status: review => reviewed_ok
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: OutsideMask ---------------------+------------------------------------------------------
Comment (by knarf):
You have the right person to talk to in the office next to you, as I understand. :)
#1590: Non ET thorn OutsideMask implicitly defines sqrt as int sqrt() ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: OutsideMask ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 22 of OutsideMask.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit