[Einstein Toolkit] #1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1150:...

[Einstein Toolkit] #1151:...

Einstein Toolkit

24 Oct 2012 24 Oct '12

10:56 a.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown --------------------+------------------------------------------------------- Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- Currently, Carpet stops the "CTTK total time" timer in Shutdown. This now emits a warning since the flesh tries to stop this timer as well. Also, the comment close to this code is wrong and needs to be changed/removed: Carpet/src/Shutdown.c:59 {{{ // Stop all timers before shutdown, since timers may rely on data // structures which are destroyed during shutdown int const ierr = CCTK_TimerStop ("CCTK total time"); }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

24 Oct 24 Oct

11 a.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: ET_2013_05 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* milestone: => ET_2013_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:16 a.m.

Comment (by hinder):

I don't think we can release the toolkit in a state where you get a warning like this on every single run you do. It doesn't give much confidence to the users.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:18 a.m.

Comment (by knarf):

We know that trying this isn't really a problem (since the double stopping is prevented). Thus, what about increasing the warning level, let's say to 4?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:20 a.m.

Comment (by eschnett):

In most cases, starting or stopping a timer multiple times is a serious problem, since the timer values will be wrong. Thus, a visible warning is needed.

We either need to correct the problem that prompted this code in Carpet, or keep the code. If no one is working on this, then we need to release with the warning.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:24 a.m.

Comment (by knarf):

Double starting/stopping will not pose a serious problem to the code. From the definitions of the warning levels:

{{{ #define CCTK_WARN_ABORT 0 /* abort the Cactus run */ #define CCTK_WARN_ALERT 1 /* the results of this run will be wrong, */ /* and this will surprise the user, */ /* but we can still continue the run */ #define CCTK_WARN_COMPLAIN 2 /* the user should know about this, */ /* but the problem is not terribly */ /* surprising */ #define CCTK_WARN_PICKY 3 /* this is for small problems that can */ /* probably be ignored, but that careful */ /* people may want to know about */ #define CCTK_WARN_DEBUG 4 /* these messages are probably useful */ /* only for debugging purposes */ }}}

Now, it all depends on how you define 'results of this run'. Most users will consider the timers to be a side product, not part of the main 'results'. CCTK_WARN_PICKY sounds best to me, but then that is still shown using simfactory defaults, thus I suggested CCTK_WARN_DEBUG (4).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:41 a.m.

Comment (by hinder):

My original suggestion was to modify the flesh function which displays the timers on shutdown to only stop the timers if they are currently running. With the new flag, isn't this straightforward to implement?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:55 a.m.

Comment (by knarf):

Currently there is no interface to get to that information outside of CactusTimers.c. We could add a function to the Cactus API: {{{ int CCTK_TimerRunning(const char *name); int CCTK_TimerRunningI(int this_timer); }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:58 a.m.

Comment (by knarf):

TimerIsRunning would probably be better.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:16 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: review Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: new => review * milestone: ET_2013_05 => ET_2012_11

Comment:

Attached is a patch which adds this functionality to Cactus and uses it to only stop this timer in case it is running.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:46 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):

* status: review => reviewed_ok

Comment:

Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:04 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: reviewed_ok => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

31 Oct 31 Oct

8:22 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: reopened Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):

* status: closed => reopened * resolution: fixed =>

Comment:

I get very many errors {{{ WARNING[L1,P1] (Cactus): CCTK_TimerStartI: Trying to start timer "Slab/copy_back_noflip" (130) which is already running. }}} when running the ML_BSSN_EE_sgw3d test of ML_BSSN_Test on 4 MPI processes.

Attached please find the test log file.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:30 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: reopened => closed * resolution: => fixed

Comment:

This was a bug in CactusNumerical/Slab. Because of a typo it tried to start the timer again when it should stop it instead. This is now fixed as of r86.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:36 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------

Comment (by rhaas):

Thank you. Making sure that I am in Slab's thorn folder when typing svn update would likely have helped.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:14 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:49 p.m.

#1141: Carpet shouldn't stop the "CCTK_ total time" timer at Shutdown ---------------------+------------------------------------------------------ Reporter: knarf | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: ET_2012_11 Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------

Comment (by knarf):

Well, I only fixed the bug after you reported it here. So, _now_ you can update.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1141#comment:15 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5090

Age (days ago)

5098

Last active (days ago)

trac@lists.einsteintoolkit.org

15 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit