#1824: shellcheck corrections for bash_utils.sh --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):

* status: new => review

#1824: shellcheck corrections for bash_utils.sh --------------------------+------------------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: ET_2015_11 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):

* status: review => reviewed_ok

Comment:

The changes look fine. I think the quoting for filenames with spaces is probably not the most important thing. Rather, I think it's important to have source files processed and checked for sanity by some tool. With compiled languages, this is the compiler, which not only compiles the code but also checks syntax and emits warnings for suspicious code. With uncompiled languages, this is up to the language runtime, which may do some cursory checks when the source file is first read, but usually will not do a deep analysis, especially in dynamic languages where the meaning of code can be changed at run-time. The code may in fact be correct, but it is impossible to tell except when that code is actually executed. For these cases, something like pychecker or pylint is very useful. I haven't used shellcheck, but I hope that it can be just as useful.