#2208: Fix small memory leak in Piraha -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: (none) Type: defect | Status: new Priority: minor | Milestone: ET_2019_02 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------

Comment (by Roland Haas):

Steve and Roland discussed this in person at SC18. Roland asks to have the prototype of the constructor changed to take a bare pointer rather than a smart-pointer to make it more obvious for callers of the Lookup objects that they store a bare pointer to the their grammar.

The current logic in piraha should be such that the grammar object exists for as long as the lookup objects exist so the pointer should not become dangling.

#2208: Fix small memory leak in Piraha -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: (none) Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2019_02 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+--------------------------------- Changes (by Roland Haas):

* status: review => reviewed_ok

Comment:

Please apply.