[Einstein Toolkit] #960: Dissipation thorn schedules LOCAL routines after GLOBAL ones

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1901: provde...

[Einstein Toolkit] #1851: HDF5...

Einstein Toolkit

18 Jun 2012 18 Jun '12

5:20 p.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ----------------------------------------------+----------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: Dissipation and SphericalSurface | ----------------------------------------------+----------------------------- Dissipation currently contains a schedule item {{{ SCHEDULE setup_epsdis AT cctk_poststep after SphericalSurface_HasBeenSet { LANG: C SYNC: epsdisA_group } "Setup spatially varying dissipation" }}} However SphericalSurface_HasBeenSet is AFTER SphericalSurface_Set which is a GLOBAL routine. Since GLOBAL routines run last in POSTSTEP (which is in EVOL) the AFTER modifier is ignored for all but the last (finest) refinement level. This can lead to the wrong surface shape to be used by the local routines.

It might actually make sense to teach the flesh about GLOBAL/LOCAL etc and refuse AFTER/BEFORE statements that span different modes. This of course depends on how much work this is and if we expect the dependency and task based scheduler to be finished soon and if there are legitimate uses for AFTER/BEFORE to span modes.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

18 Jun 18 Jun

9:14 p.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+---------------------------------------

Comment (by eschnett):

Modes must die. The sooner the better. There is no way to fix them.

See also the discussion at https://en.wikipedia.org/wiki/Mode_(computer_interface).

Having said this, patches to avoid errors are always welcome, unless they are too complex.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

19 Jun 19 Jun

2:28 a.m.

Comment (by hinder):

Do you have some ideas for how to replace modes with something better? I imagine this is related to the data-driven scheduler ideas.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

20 Jun 20 Jun

10:15 a.m.

Comment (by eschnett):

Instead of modes, the schedule entry should specify which regions of grid functions a routine reads and writes. We were currently thinking of region such as "everywhere", "interior", or "boundary" -- extending this to "all components on this level", or "all levels" should do the trick.

We may still need modes for internal routines e.g. in driver-related or multiblock-related thorns, but I hope to be able to avoid this in physics thorns.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7 Jul 7 Jul

7:20 p.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

Comment:

The attached two patches (one with code changes and a compressed one with changes to the test data to stay below the 250K attachment size limit) add special logic to schedule setup_eps_diss in global mode in poststep. The extra logic ensures that SYNC only happens on the levels that the local routine would run on rather than all levels. As far as I can tell this cannot be achieved with SYNC statements in schedule.ccl and requires direct interaction with Carpet and CCTK_SyncGroup().

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:29 p.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

Comment:

Instead of replicating Carpet's logic, there could be a level-mode routine that does nothing except record on which levels it is called. A subsequent global loop-level mode routine could call CCTK_SyncGroup on these levels. Would this work (and be simpler than the current code?)

If not, please apply the patch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:45 p.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+---------------------------------------

Comment (by rhaas):

Attached please find a patch (loose-interaction.patch) which accomplishes this. It no longer replicates Carpet's logic but at the price of introducing a second function and more #ifdefs. Which one is nicer depends on how crucial it is to keep user thorns ignorant of Carpets internal logic I guess. Both versions are fine with me (though I slightly prefer the first version since it does not require a static variable). Alternatively and since I know of several other thorns that could benefit from something like this, how about defining (yet another) aliased function to return "RunOnLevel(rl)" which returns {{{cctk_iteration%do_every == 0}}} or {{{(cctk_iteration-1)%do_every == 0}}} depending on whether we are in EVOL or not? Ie. an aliased routine that exposes Carpet's decision (but not the logic behind it) to the user code in a hopefully controlled manner?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8 Jul 8 Jul

10:04 a.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+---------------------------------------

Comment (by eschnett):

Such an aliased function is a good idea. Presumably, even Carpet itself may benefit from using it...

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 Oct 22 Oct

1:33 a.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Dissipation and SphericalSurface ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => reopened

Comment:

changed to re-opened to remind me (rhaas) to write the aliased function mentioned in comment:7

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

27 May 27 May

9:48 a.m.

#960: Dissipation thorn schedules LOCAL routines after GLOBAL ones ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: Dissipation and SphericalSurface ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reopened => closed * resolution: => fixed

Comment:

This issue is fixed along with an issue in AHFinderDirect in #1880 I created a new ticket for the aliased functions proposed in here #1901

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/960#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3786

Age (days ago)

5225

Last active (days ago)

trac@lists.einsteintoolkit.org

9 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit