#1523: Use Piraha to Parse all CCL files -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Cactus_4.3.0 Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- Piraha should be used to parse all the CCL files. This would give us a well-defined grammar and the ability to let other tools use the CCL files in a reliable way.
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.3.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by sbrandt):
* owner: => sbrandt * status: new => accepted
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* milestone: Cactus_4.3.0 => Cactus_4.4.0
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
Is this going anywhere?
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by sbrandt):
See the piraha_everywhere branch of the flesh.
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
Just a note that the proposed branch seems to work well also with the Parma-thorns (compilation runs through and no new tests fail compared to master branch).
#1523: Use Piraha to Parse all CCL files --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
To be included in the flesh it should ideally adhere to the flesh coding standards, see #1520 .
#1523: Use Piraha to Parse all CCL files -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: Steven R. Brandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------
Comment (by Roland Haas):
Piraha is now used but does not adhere to the flesh coding standards.
#1523: Use Piraha to Parse all CCL files -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: Steven R. Brandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------
Comment (by Roland Haas):
Piraha's source code should be cleaned up so that it adheres to the flesh coding standards.
#1523: Use Piraha to Parse all CCL files -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: Steven R. Brandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------
Comment (by Steven R. Brandt):
I'd thought I'd done this. Can you point me to the coding standards you want me to adhere to? Thanks.
#1523: Use Piraha to Parse all CCL files -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: Steven R. Brandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------
Comment (by Roland Haas):
Please see: https://bitbucket.org/cactuscode/cactus/raw/387fae8c18ff04c3368f038d708b801b... section A2 in particular the grdoc headers and the indentation rules.
#1523: Use Piraha to Parse all CCL files -------------------------------+--------------------------------- Reporter: Steven R. Brandt | Owner: Steven R. Brandt Type: enhancement | Status: accepted Priority: optional | Milestone: Cactus_4.4.0 Component: Cactus | Version: development version Resolution: | Keywords: -------------------------------+---------------------------------
Comment (by anonymous):
Also please see the comments in #1520 which points to the online version of the maintainers guide as well as naming conventions for internal functions.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit