#898: use characteristic speed +/-c for Bx in HLLEM -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro | -----------------------------------+---------------------------------------- the attached patch (against trunk) adds a new parameter decouple_normal_Bfield which defaults to yes (and changes the default behaviour) to GRHydro's MHD code when divergence cleaning is used. Reasons for this are given eg in Mignonoe et al. arXiv:1001.2832v2 section 3.1. This patch allows us to run the rotor test without having to resort to the LLF flux formula (which also uses +/- characteristic speed but for all variables) and does not seem to cause any problems in the TOV tests that Philipp ran. Bruno says it helps with the cylindrical blast as well.
Ok to include in the release (given that it is tunable at runtime) even though we are in the "no major change" phase?
#898: use characteristic speed +/-c for Bx in HLLEM ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#898: use characteristic speed +/-c for Bx in HLLEM ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by bmundim):
This is indeed a bug fix for the magnetized HLLE solver with divergence cleaning. Not only the rotor test improves but also preliminary tests of the cylindrical explosion shows now that it is possible to use HLLE solver for this stringent test.
Please apply this patch.
#898: use characteristic speed +/-c for Bx in HLLEM ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: review => reviewed_ok
#898: use characteristic speed +/-c for Bx in HLLEM ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit