[Einstein Toolkit] #1469: Invalid integer parameters cause a confusing error message

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1513: git...

[Einstein Toolkit] #1499: Error in...

Einstein Toolkit

5 Nov 2013 5 Nov '13

10:22 a.m.

#1469: Invalid integer parameters cause a confusing error message --------------------+------------------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- If an integer-valued parameter is assigned a value such as 100000000000000000000000 which is too large to fit into an integer, the Piraha parameter parser interprets it as a real and complains

{{{ (line 15 of sim.par): -> Parameter type mismatch INT != REAL }}}

This message is not very helpful. A better error message might be:

{{{ (line 15 of sim.par): -> Parameter MyThorn::mypar cannot be set to the value 10000000000000000000 as this is not a valid INT value }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

6 Nov 6 Nov

12:26 a.m.

#1469: Invalid integer parameters cause a confusing error message ---------------------+------------------------------------------------------ Reporter: hinder | Owner: brandt Type: defect | Status: assigned Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):

* owner: => brandt * status: new => assigned

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:50 a.m.

Comment (by sbrandt):

Please check to see if the attached patch makes things better.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 Dec 2 Dec

2:09 p.m.

#1469: Invalid integer parameters cause a confusing error message ---------------------+------------------------------------------------------ Reporter: hinder | Owner: sbrandt Type: defect | Status: assigned Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* owner: brandt => sbrandt

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 Jan 6 Jan

11:58 a.m.

#1469: Invalid integer parameters cause a confusing error message ---------------------+------------------------------------------------------ Reporter: hinder | Owner: sbrandt Type: defect | Status: closed Priority: major | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* status: assigned => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:53 p.m.

#1469: Invalid integer parameters cause a confusing error message ---------------------+------------------------------------------------------ Reporter: hinder | Owner: sbrandt Type: defect | Status: reopened Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: closed => reopened * resolution: fixed =>

Comment:

This seems to trigger a lot of testsuite failures, e.g., https://build.barrywardell.net/job/EinsteinToolkit/lastBuild/testReport/juni...

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:48 p.m.

#1469: Invalid integer parameters cause a confusing error message ---------------------+------------------------------------------------------ Reporter: hinder | Owner: sbrandt Type: defect | Status: reopened Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by hinder):

If a fix is not immediately obvious, this should be reverted. It means the flesh is broken, which is quite serious, and not supposed to happen :(

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:48 p.m.

#1469: Invalid integer parameters cause a confusing error message ----------------------+----------------------------------------------------- Reporter: hinder | Owner: sbrandt Type: defect | Status: reopened Priority: blocker | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ----------------------+----------------------------------------------------- Changes (by hinder):

* priority: major => blocker

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4:17 p.m.

#1469: Invalid integer parameters cause a confusing error message ----------------------+----------------------------------------------------- Reporter: hinder | Owner: sbrandt Type: defect | Status: closed Priority: blocker | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: ----------------------+----------------------------------------------------- Changes (by sbrandt):

* status: reopened => closed * resolution: => fixed

Comment:

Fixed. Very sorry everyone.

This new version definitely solves the problem. It detects values out of range for both double and int.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1469#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4659

Age (days ago)

4721

Last active (days ago)

trac@lists.einsteintoolkit.org

8 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit