#1227: incorrectly quoted regular expressions in aclocal.m4 -------------------+-------------------------------------------------------- Reporter: rhaas | Type: defect Status: new | Priority: minor Milestone: | Component: Cactus Version: | Keywords: -------------------+-------------------------------------------------------- m4 uses square brackets as quotation characters and removes one set of them per argument call. This affects regular expressions that contain character ranges. This in turn affect some HAVE_XXX macros where XXX contains invalid characters eg. XXX=math.h . The attached patch adds an extra level of [] around where the result is passed to a function. Also it seems as if the system provided AC_CHECK_FUNCS does not properly quote its third argument when passing it to AC_CHECK_FUNC. Hence I add an extra round of [] whenever it is used.
This is a mess.
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
The patch replaces "sed" by "seda". What is "seda"?
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
A typo. Sorry.
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
Updated patch that removes a stray comma appearing in configure. Moves arguments CCTK_CHECK_LIB_FUNC around. Currently the extra arguments are ever provided so are empty.
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
#1227: incorrectly quoted regular expressions in aclocal.m4 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in rev 4953 of the flesh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit