#2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts ------------------------+--------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: SimFactory | Version: development version Keywords: | ------------------------+--------------------------------------------------- Right now, in line 165 of simfactory/lib/sim-sync.py {{{ cmd = "%s --rsh=%s --rsync-path=%s %s %s %s" % (rsynccmd, simlib.QuoteSafe(sshcmd), simlib.QuoteSafe(machineEntry.rsynccmd), rsyncopts, machineEntry.rsyncopts, arguments) cmd = "%s %s" % (cmd, " ".join(rsyncoptions)) }}} the hard-coded set of options in rsycnoptions {{{ rsyncoptions = [ '--checksum', '--compress', '--delete', '--hard-links', '--links', '--partial', '--perms', '--progress', '--recursive', '--sparse', '--stats', #'--times', '--verbose'] }}} overwrites the options passed in via the mdb (machineEntry.rsyncopts) since it appears later on the commmand line.
This is (currently) an issue for minerva, whose file system does not support hard-links, since there is no way to pass in a {{{--no-hard-links}}} option for just minerva.
Typically we don't have hard-links in our code trees, though it is certainly not something that is expected to never happen (eg I do have some hard links).
#2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Pull request is here: https://bitbucket.org/simfactory/simfactory2/pull- requests/22/rhaas-rsyncopts/diff
#2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by rhaas):
Anyone? If not I will apply this sometime during the week of Dec. 18th.
#2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied as git hash 9e4935c "sim-sync: make it possible to override hard- coded rsync options" of simfactory2.
trac@lists.einsteintoolkit.org