[Einstein Toolkit] #1791: Allow aligning the interior of grid functions in looping macros
#1791: Allow aligning the interior of grid functions in looping macros -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- Currently, when grid functions are aligned, Cactus expects their origin to be aligned. These changes update the looping macros to allow aligning the interior of grid functions instead. Whether and how grid functions are aligned is still determined by the driver -- this only makes it possible to still use the looping macros in this case.
Implemented in <https://bitbucket.org/cactuscode/cactus/pull-request/16 /allow-aligning-the-interior-of-grid/diff> and <https://bitbucket.org/cactuscode/cactustest/pull-request/1/allow- aligning-the-interior-of-grid/diff>.
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
Looks fine to me. In fact I like the new way of making sure the final offset is smaller than the stride {{{#!diff - (bsnl (' const int cctki0_ioff = ' . (sep '', rpt '[I==1?(cctki0_imin:+cctki0_[C-1]ash*([C]]') . (sep '', rpt ')') . ' & (cctki0_istr-1);')), + (bsnl (' const int cctki0_ioff0 = ' . (sep '', rpt '[I==1?(cctki0_imin:+cctki0_[C-1]ash*([C]]') . (sep '', rpt ')') . ' + cctki0_imod;')), + # TODO: Omit this when grid arrays are aligned + (bsnl ' const int cctki0_ioff = cctki0_ioff0 % cctki0_istr;'), }}} better than the previous one since it allows for strides that are not powers of 2 (though I doubt we'll ever encounter those).
One thing that had a me a bit confused is the name "_mod" used to designate the offset argument (and not a modulus).
Please apply.
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Merged.
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: closed => reopened * resolution: fixed =>
Comment:
I had to revert f712bc6 (my bad for not trying the change beforehand) and believing the review.
The problem is that TestLoopCXXVectorized uses an un-pushed (?) macro CCTK_LOOP3STRMOD_ALL, and thus, fails to build.
https://bitbucket.org/cactuscode/cactustest/commits/all https://build.barrywardell.net/job/EinsteinToolkit/815/console
#1791: Allow aligning the interior of grid functions in looping macros --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* owner: => eschnett * status: reopened => assigned
trac@lists.einsteintoolkit.org
-
Einstein Toolkit