#1147: Link all thorn source files -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- The attached patch adds configuration options allowing people to ensure that all thorn source files make it into the executable. Among other things, this ensures that each routine has a unique name.
For example, on systems using GNU ld, these options enable this behaviour: {{{ BEGIN_WHOLE_ARCHIVE = -Wl,--whole-archive END_WHOLE_ARCHIVE = -Wl,--no-whole-archive }}}
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
The patch looks fine, but Roland suggested to use a bit different naming for the options and I agree:
BEGIN_WHOLE_ARCHIVE_FLAGS END_WHOLE_ARCHIVE_FLAGS
With this, please apply.
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
Please also mention the flags and one or two examples in doc/UsersGuide/Notes.tex in the section for these options.
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Applied.
#1147: Link all thorn source files --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit