[Einstein Toolkit] #1034: make maxnphi and maxntheta parameters of SphericalSurface steerable
#1034: make maxnphi and maxntheta parameters of SphericalSurface steerable -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: SphericalSurface | -----------------------------------+---------------------------------------- this patch make two parameters of SphericalSurface steerable. Since they control the size of grid arrays that are checkpointed, changing them requires some care, but is fine if eg. a run had no SF turned on initially and one wants to turn them on when recovering from a checkpoint.
#1034: make maxnphi and maxntheta parameters of SphericalSurface steerable ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: SphericalSurface ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1034: make maxnphi and maxntheta parameters of SphericalSurface steerable ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: SphericalSurface ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
Is there a warning / an error when a variable changes size during recovery?
#1034: make maxnphi and maxntheta parameters of SphericalSurface steerable ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: SphericalSurface ------------------------------------+---------------------------------------
Comment (by rhaas):
I would expect that CarpetIOHDF5 aborts with "variable read only partially" if one increases these parameters. In my case I set the skip_variables parameter to not recover the radius field (which was fine since the usage case was going from nsurfaces==0 to nsurfaces > 0).
Applied as rev 50 of SphericalSurfaces.
#1034: make maxnphi and maxntheta parameters of SphericalSurface steerable ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: SphericalSurface ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit