#1313: GRHydro bugfixes -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro | -----------------------------------+---------------------------------------- due to the code freeze, I will only propose bug fixes until the release branch has been created.
Attached are three of those. The first one is related to Christian Reisswig's bugfixes in the excision handling, the second one is a trivial patch that affects how divB is computed (no change in output due to the variable in question being initialized to zero before). The last one reverts the meaning of the (newly introduced) parameters cyl_rho_inner and *_outer so that the values for _outer are used for large "r" and inner for small "r".
#1313: GRHydro bugfixes ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by knarf):
Is it just me or aren't there any patches to look at yet?
#1313: GRHydro bugfixes ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
Not yet. Had to go to a meeting after I had created the ticket. There will be another email once I set the state to review.
#1313: GRHydro bugfixes ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Review now! However it's currently one person one vote. And that person is Frank :-).
#1313: GRHydro bugfixes ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1313: GRHydro bugfixes ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 504 and 505 of GRHydro, applied as rev 210 of GRHydro_InitData
trac@lists.einsteintoolkit.org
-
Einstein Toolkit