#813: Fix all thorns that attempt reductions in local mode -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: task | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- Recently these produce a level three warning (simfactorie's default) whenever they attempt to do so and clutter the log files.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
It would help to list the thorns that do this here, and probably open a separate ticket for each of them (in case it's not too many).
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
I currently know of
* SphericalSurface::SphericalSurface_SetupRes * none other so far
It turns out the thorn that gave me most warnings was a private thorn (author has been notified).
The SphericalSurface routine is actually fairly complicated since it first accesses grid functions then reduces then accesses some more based on information just collected.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Is this routine (SphericalSurface::SphericalSurface_SetupRes) used often? I believe it offers the capability to examine the grid structure and then choose a resolution for the spherical surface that corresponds to that of the 3D grid. While superficially convenient, this is (a) not adaptive, (b) could be done in the parameter file (since one knows the resolutions there), and (c) does not permit convergence tests.
If this feature is rarely used, then it does not need to be corrected.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
the attached patch has CarpetReduce use CCTK_ScheduleQueryCurrentFunction to find out which thorn is calling reduction in local or singlemap mode.
Ok to apply to Carpet?
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
applied.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
I just found that RotatingSymmetry90 also contains a reduction call (in rotatingsymmetry90.c line 175). However since it uses TAT/Slab it "can only be used if there is a single local component per MPI process" anyway. Also moving the affected lines outside into a LEVEL mode routine defeats an optimization to quit early if there is nothing to do and the routine in question is not a scheduled routine to begin with. It does however make runs with RotatingSymmetry90 produce very large log files (if -L3 is used).
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => reopened
Comment:
We should either fix the symmetry thorns or revert (my) extra warnings in the array reduction routines in carpetreduce (the GF reduction routines seem to cause fewer warnings).
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reopened => review
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
We should increase the warning level for the release (L4?) since this is the safest option, and then discuss what to do in the development branch later.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reopened
Comment:
done. I set the level to WARN_DEBUG (L4) in 12ee1105096a. I am leaving this ticket open for possible re-review of the patches to rotatingsymmetry* after the release.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reopened Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* milestone: => ET_2012_11
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reopened => review
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
Please change the variable name "time_of_extent_computation" to "valid_for_iteration" or similar, and/or add a comment to the variable's declaration.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
applied as rev 74 and 77 of RotatingSymmetry90 and RotatingSymmetry180 respectively. I changed the variable name to extent_valid_for_iteration.
#813: Fix all thorns that attempt reductions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: closed Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit