#601: Wanted: Routine to convert table to string -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- It would be nice to have a routine that converted a table to a string, using the same syntax that is accepted by Util_TableCreateFromString. This is a nice, compact notation that is much easier to read than the internal table dumping syntax.
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
This patch includes (and supercedes) the patch attached to #467.
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
(The attached patch does not convert the table to a string and return it - as far as I can tell it prints a nicer-formatted version to a FILE stream.)
Perhaps the names of the new functions, Util_TablePrint and Util_TablePrintString, could be changed to reflect that the only difference between them is that the latter prints in a friendlier, more- compact format (assuming I understood the patch correctly).
These functions also need to be documented in the reference manual.
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: review => reopened
Comment:
Please add the 'review' state again with a new patch.
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
I suggest to rename Util_TablePrintString to Util_TablePrintPretty, keep the remainder of the patch as is, and add documentation. I take the lack of comments on other issues as acceptance.
Do you really need to see a new patch?
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
I don't need to see a new patch. Your suggestions sound good, and I would be happy for them to be committed as you described them. We commit to a Cactus API like this at the next release, I suppose.
#601: Wanted: Routine to convert table to string --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reopened => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit