#1353: GRHydro updates -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro | -----------------------------------+---------------------------------------- this set of patches is need (or at least the MHD ones are) to be able to actually run the runs of the ET MHD paper. So even this late in the game, I'd like to get them into the release if at all possible.
There are also a number of bugfixes mostly for the hot eos code.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by knarf):
Which of these are important for the release (paper) ?
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
0007 0004 are important bugfixes for the paper (and needed). 0009 0008 0001 are bugfixes. 0003 is an enhancement. the others are cosmetic or do not change things.
Note that there will be more changes in the tests to get eg the WENO test to work.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by knarf):
Please apply 0004. 0007 is a too large beast for me now. It either has to wait or find another reviewer.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
one more bugfix, 0013 which corrects where prim2coninitial computes the magnetic field.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by pmoesta@…):
Replying to [comment:4 knarf]:
Please apply 0004. 0007 is a too large beast for me now. It either has
to wait or find another reviewer. Please apply 0007 as well.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by pmoesta@…):
Replying to [comment:5 rhaas]:
one more bugfix, 0013 which corrects where prim2coninitial computes the
magnetic field. Please apply.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
Applied 4, 7, 13 as rev 510, 511 and 512 of GRHydro. Please consider reviewing the bugfix patches 1,8,9 as well (affect hot EOS runs).
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
Anyone? If not then I will apply them by Monday.
#1353: GRHydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied 1,2,3,5,6,8,9,10,11,12 as rev 526 to 535.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit