#846: Support CCTK_REAL4 in AHFinderDirect -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- {{{
Index: src/include/config.h =================================================================== --- src/include/config.h (revision 1563) +++ src/include/config.h (working copy) @@ -54,8 +54,15 @@ * FIXME: this assumes fp == C 'double' * CCTK_REAL_PRECISION_{4,8,16} are helpful, but not quite enough) */ +#include <cctk.h> #undef FP_IS_FLOAT +#undef FP_IS_DOUBLE +#ifdef CCTK_REAL_PRECISION_4 +#define FP_IS_FLOAT +#endif +#ifdef CCTK_REAL_PRECISION_8 #define FP_IS_DOUBLE +#endif
#if defined(FP_IS_FLOAT) #define FP_SCANF_FORMAT "%f" }}}
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
Wouldn't this patch invalidate the comment directly above it? Otherwise it looks ok to apply, but I didn't test. I don't have a configuration using CCTK_REAL4 for testing right now.
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
The code still doesn't test whether a CCTK_REAL8 is really a double, hence the comment remains valid. Of course, this is only of theoretical interest, since it would be very strange to have a machine where a double does not use 8 bytes.
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* milestone: => ET_2012_05
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
Please apply
#846: Support CCTK_REAL4 in AHFinderDirect ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit