#897: Hydro_InitExcision tests failing -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: Hydro_InitExcision | -----------------------------------+---------------------------------------- with the atmosphere fixes from r332 of GRHydro the following Hydro_InitExcision tests started to fail: * diag_pugh_tvd (from Hydro_InitExcision) * halfsphere_pugh_ppm (from Hydro_InitExcision) * halfsphere_pugh_tvd (from Hydro_InitExcision) * sphere_pugh_tvd (from Hydro_InitExcision) * x_pugh_tvd (from Hydro_InitExcision)
the attached patch regenerates the data. I have checked that reverting the GRHydro patch makes the tests pass. Ok to apply?
#897: Hydro_InitExcision tests failing ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Hydro_InitExcision ------------------------------------+---------------------------------------
Comment (by rhaas):
The patch is too large to attach and can be found here: http://www.tapir.caltech.edu/~rhaas/897/regenerate_tests.patch
#897: Hydro_InitExcision tests failing ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Hydro_InitExcision ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#897: Hydro_InitExcision tests failing ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Hydro_InitExcision ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
The patch only updates the testsuites. Please apply.
#897: Hydro_InitExcision tests failing ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: Hydro_InitExcision ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Well yes. But I can *always* make failing test suite work but *only* updating test suites. :-) Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit