[Einstein Toolkit] #681: LSUThorns/Vectors: Update Kranc-specific code

List overview All Threads
Download

newer

older

[Einstein Toolkit] #837: valgrind...

[Einstein Toolkit] #834: Provide...

Einstein Toolkit

26 Nov 2011 26 Nov '11

10:32 a.m.

#681: LSUThorns/Vectors: Update Kranc-specific code -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+----------------------------------------

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

26 Nov 26 Nov

10:34 a.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

16 Jan 16 Jan

9:42 a.m.

Comment (by hinder):

I don't quite understand the undefinition of E. If the symbol is used elsewhere with a different meaning, how does that interact with Kranc? Could you elaborate?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:56 a.m.

Comment (by eschnett):

#define does not have name scopes. If E is defined, we assume it comes from Kranc, and redefine it to its proper value with vectorisation (i.e. with ToReal). If it is not defined, then we don't define it here either.

If we #define E here unconditionally, and some code tries to use it as a variable/type name, then this will fail. This would insert the identifier E into all source code, even those not using Kranc.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 Jan 17 Jan

3:27 a.m.

Comment (by hinder):

OK I see. Would it make sense to change the conditional to #ifdef KRANC_C so that you can be sure you are only affecting Kranc thorns? It might be that other header files also define E for their own purposes. For Kranc- generated thorns, we can be fairly sure that this is not the case.

Now that I think about it some more, why is this replacement handled here by macros? Wouldn't it make more sense to have E -> ToReal[E] in Kranc when vectorisation is enabled (and similarly for Pi)? Then Vectors would not need to know about a Kranc-specific symbol, and Kranc would be treating these constants just like it treats parameters (for example).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:51 a.m.

Comment (by eschnett):

Yes, using KRANC_C would be better.

Yes, doing this in Kranc would also work.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

27 Jan 27 Jan

9:02 a.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => reopened

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4 Feb 4 Feb

5:50 p.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by barry.wardell):

So the suggestion is to have something like to two patches I have just attached (one for Vectors, and the other for Kranc)?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:16 p.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by eschnett):

Yes, similar to these patches.

I plan to commit my new version of the patch (without your patches) later today, and you could apply them then.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:21 p.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by eschnett):

Applied.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

26 Apr 26 Apr

12:24 p.m.

#681: LSUThorns/Vectors: Update Kranc-specific code ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by barry.wardell):

* status: reopened => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/681#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5279

Age (days ago)

5431

Last active (days ago)

trac@lists.einsteintoolkit.org

10 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit