[Einstein Toolkit] #1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep ----------------------------------------+----------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: new Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Keywords: HydroBase | ----------------------------------------+----------------------------------- Some routines in GRHydro query whether a point is excised using hydrobase's excision mask. HydroBase initializes the excision mask to zero in certain groups. However, this initialization should happen before any other code reads the excision mask. Since GRHydro reads the excision mask in Con2Prim, which is scheduled in MoL_PostStep, the mask should be set before MoL_PostStep!
Most notably, this is required in post_recover_variables (since the mask is not checkpointed and thus we critically rely on a correct mask initialzation), and also in post_regrid, where new points must be correctly initialized.
I attach a simple patch that fixes this issue.
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: review Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by knarf):
* status: new => review
Comment:
I wonder why this patch is necessary. It is correct, and should be applied, but doesn't Cactus schedule things sorted alphabetically anymore? HydroBase* should have been scheduled before MoL*.
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: closed Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by knarf):
* status: review => closed * resolution: => fixed
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: reopened Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by knarf):
* status: closed => reopened * resolution: fixed =>
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: review Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by knarf):
* status: reopened => review
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: reviewed_ok Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1310: HydroBase should initialize excision mask before MoL_PostStep since it is used in MoL_PostStep -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: reisswig@… Type: defect | Status: closed Priority: critical | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: HydroBase -----------------------------------------+---------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied by Christian as rev 60 of HydroBase.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit