[Einstein Toolkit] #1932: ML_BSSN: other_timelevels Parameter Not Respected

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1865:...

[Einstein Toolkit] #1965: use...

Einstein Toolkit

27 Jun 2016 27 Jun '16

10:20 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected --------------------------------+------------------------------------------- Reporter: zachetie@… | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Other | Version: development version Keywords: | --------------------------------+------------------------------------------- At the Jun 27, 2016 ET telecon, we found the following bug in McLachlan/ML_BSSN:

Inside the ET_2016_05 ML_BSSN/schedule.ccl, you'll notice the following lines: STORAGE: ML_Ham[timelevels] STORAGE: ML_mom[timelevels] STORAGE: ML_cons_detg[timelevels] STORAGE: ML_cons_Gamma[timelevels] STORAGE: ML_cons_traceA[timelevels]

in all of these lines, "timelevels" should be replaced by "other_timelevels".

This should result in significantly increased memory usage in the latest ML_BSSN (possibly at the 10-20% level), particularly in vacuum evolutions.

Related to this problem, I noticed that in a previous version of McLachlan (2015_05, where the above issue does not exist), all constraints are being stored in checkpoint files, despite having only one timelevel. ML_BSSN_Helper is supposed to overwrite the ML_BSSN/interface.ccl request to set the Checkpoint="no" tag.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

23 Sep 23 Sep

8:50 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------

Comment (by knarf):

#1960 was marked as duplicate of this bug. It looks like a reasonable proposal to me to replace 'timelevels' by 'other_timelevels' in these cases. Concerning checkpointing: if other_timelevels is indeed 1, there is no need to store them. Would it be conceivable that someone might actually want to store them (and other_timelevels is set to a high enough value)?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:35 a.m.

Comment (by rhaas):

Currently, when {{{other_timelevels}}} is 1 the code in ML_BSSN_Helper will disable checkpointing, prolongation and persistency. Though looking at the code at least the prolongation part is stated to be handled by Kranc itself (Erik and Ian would know details it seems).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:46 a.m.

Comment (by eschnett):

Kranc should use {{{other_timelevels}}} for some grid functions, but it doesn't. This broke at some point, and should be corrected. Kranc's logic for which parameter to use for which grid functions is located at a rather low-level place, and I don't know how to pass the respective information there.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:42 p.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------ Changes (by rhaas):

* status: new => review

Comment:

The patch to McLachlan_BSSN.m in https://bitbucket.org/einsteintoolkit/mclachlan/pull-requests/3/ml_bssn- use-other_timelevels-parameter-for/diff seems to do this.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

24 Sep 24 Sep

8:07 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------

Comment (by eschnett):

This looks good; we should merge this. There might be fall-out in terms of parameter files that don't set {{{other_timelevels}}} correctly, so we should merge this now, not before the release.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

25 Sep 25 Sep

9:52 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: ---------------------------------+------------------------------------------ Changes (by rhaas):

* status: review => closed * resolution: => fixed

Comment:

Applied as git hash fb4b813 of McLachlan.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:33 p.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: ---------------------------------+------------------------------------------

Comment (by rhaas):

Replying to [comment:2 rhaas]:

...

Currently, when {{{other_timelevels}}} is 1 the code in ML_BSSN_Helper

will disable checkpointing, prolongation and persistency. Though looking at the code at least the prolongation part is stated to be handled by Kranc itself (Erik and Ian would know details it seems).

I just tried this with the attached qc0_mclachlan.par file and Kranc (at least in the release branch where the comment appears) does not seem to turn off prolongation: {{{ ERROR from host 127.0.0.1 process 0 while executing schedule bin (none), routine (no thorn)::(no routine) in thorn CarpetLib, file configs/sim/build/CarpetLib/ggf.cc:334: -> The variable "ML_BSSN::cS" has only 1 active time levels, which is not enough for boundary prolongation of order 2 }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:36 p.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------ Changes (by rhaas):

* status: closed => reopened * resolution: fixed =>

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

30 Sep 30 Sep

9:07 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------

Comment (by eschnett):

Apparently Kranc does not yet handle this. We need to remove the respective "#if 0" in "mclachlan/m/prototype/ML_BSSN_Helper/src/SetGroupTags.c" to re-activate the mechanism there, then regenerate McLachlan.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3 Oct 3 Oct

10:44 a.m.

#1932: ML_BSSN: other_timelevels Parameter Not Respected ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------

Comment (by rhaas):

Hmm it seems https://bitbucket.org/einsteintoolkit/mclachlan/pull- requests/3/ml_bssn-use-other_timelevels-parameter-for/diff has already been applied (by me? I don't think I intended to).

Using it and the reactivated code in ML_BSSN_Helper the testsuite fails in four tests: * magnetizedTOV (from IllinoisGRMHD) * ml-gw1d-small (from PeriodicCarpet) * ml-gw1d-small-amr (from PeriodicCarpet) * testperiodicinterp (from PeriodicCarpet)

The CarpetPeriodic ones fail with a SEGFAULT while the IllinoisGRMHD one fails reporting missing time levels for time prolongation. I attach the log files of the 4 tests.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1932#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3658

Age (days ago)

3756

Last active (days ago)

trac@lists.einsteintoolkit.org

10 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit