#901: bashism in ThornDoc --------------------+------------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: new Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- ThornDoc uses '==' within 'test' to test for something being equal. However, for shell scripts this should be '='. This works in bash, since it also accepts '==', but it does not work for /bin/sh by default, which is what ThornDoc claims to be a script for. The effect is that 'make THORN-ThornDoc' prints a lot of warnings.
The attached patch fixes this by replacing '==' with '='.
#901: bashism in ThornDoc ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* status: new => review
#901: bashism in ThornDoc ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply. Please check ArrangementDoc for similar issues.
#901: bashism in ThornDoc ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by hinder):
Would it be safer to change these scripts to require bash?
#901: bashism in ThornDoc ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: closed Priority: minor | Milestone: ET_2012_05 Component: Cactus | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
I applied the same patch to ArrangementDoc, thanks for the hint. We could resolve it by letting the scripts use bash instead, but I don't think we should unless there is some reason for using bash features.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit