#1657: ExternalThorns/pciutils ignores most option list options -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: pciutils | -----------------------------------+---------------------------------------- It does not contain a configure script and its Makefile hard-codes the compiler and linker to be gcc. This is an issue if LDFLAGS (or CFLAGS possibly) contain {{{-openmp}}} like they do when using the intel compiler. Also using mkl could (should) be done with the {{{-mkl}}} switch to the intel compiler but gcc (as used in pciutils) will naturally not accept this.
#1657: ExternalThorns/pciutils ignores most option list options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: pciutils ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
This patch removes the hard-coded CC and AR from the Makefile and builds pciutils using MKL and -openmp flags with the intel compiler. It also builds on a stock Linux (Debian Squeeze) system where gcc is used. I have not tested this on a Mac (see #1658).
#1657: ExternalThorns/pciutils ignores most option list options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: pciutils ------------------------------------+--------------------------------------- Changes (by hinder):
* priority: major => minor
Comment:
Changing priority to minor as the thorn has been removed from the ET thornlist. As always, please re-raise if you disagree.
#1657: ExternalThorns/pciutils ignores most option list options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: pciutils ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
Looks good without trying: please apply.
#1657: ExternalThorns/pciutils ignores most option list options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: pciutils ------------------------------------+--------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
applied in r28.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit